This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Build gdb.opt/inline-*.exp tests at -O0, rely on __attribute__((always_inline)) (was: Re: [PATCH v3 24/34] Push thread->control.command_interp to the struct thread_fsm)
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Jul 2016 13:05:41 +0100
- Subject: Re: [PATCH] Build gdb.opt/inline-*.exp tests at -O0, rely on __attribute__((always_inline)) (was: Re: [PATCH v3 24/34] Push thread->control.command_interp to the struct thread_fsm)
- Authentication-results: sourceware.org; auth=none
- References: <1462538104-19109-25-git-send-email-palves@redhat.com> <20144b4c-11ee-fc84-e3ad-b9992f14ce15@redhat.com> <2455620.gRHMPhxaPl@e108577-lin>
On Friday 01 July 2016 16:24:38 Thomas Preudhomme wrote:
> On Friday 01 July 2016 13:05:35 Pedro Alves wrote:
> > On 07/01/2016 12:02 PM, Thomas Preudhomme wrote:
> > > The new tests added by this patch fail for arm-none-eabi targets because
> > > -O2 leads to instructions to be reordered widely. In this case, the
> > > instruction that follows the first one for line 64 is related to line 70
> > > so the test is failing. Shouldn't this test be compiled with -Og and
> > > probably also -finline- small-functions -findirect-inlining
> > > -fpartial-inlining which relates to inlining and are included in -O2.
> >
> > Or even just plain -O0. See the commit log below. WDYT?
>
> I'm not very familiar with GDB but the description looks great indeed.
> Thanks!
Hi Pedro,
What is the status of that patch?
Best regards,
Thomas