This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable
- From: Tom Tromey <tom at tromey dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Thu, 14 Jul 2016 10:49:13 -0600
- Subject: Re: [RFA 0/6] Add -Wunused-but-set-parameter and -Wunused-but-set-variable
- Authentication-results: sourceware.org; auth=none
- References: <1465248812-23902-1-git-send-email-tom@tromey.com> <CAH=s-POD0ONLxHsoMFooOibZ58TB_UjW85GXioaM5_koQ2FBCA@mail.gmail.com> <87zipmokf3.fsf@tromey.com> <CAH=s-PMEx3qg7-MtZequ2kK=RE32RYPGPHk2CwF7AFqRw+cHQw@mail.gmail.com>
Yao> Can you use cross compiler to cross build native gdb to catch these
Yao> warnings?
Tom> It seems I won't get around to this. How about I check in everything
Tom> except the patch to enable the warning? That way at least some progress
Tom> has been made.
Yao> Yes, that is fine by me.
Thanks. I've pushed the series except for the final patch.
I filed a bug for the last step:
https://sourceware.org/bugzilla/show_bug.cgi?id=20371
I tried adding a couple of other warnings recently, namely
-Wmisleading-indentation (gdb is clean here) and -Wduplicated-cond
(this exposed one real bug, filed; and a couple of minor non-bugs in the
python directory).
However, since I can't really do builds on other platforms, someone else
will have to submit those patches.
Tom