This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add method/format information to =record-started
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 05 Jul 2016 14:50:51 +0100
- Subject: Re: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220.22286-1-simon.marchi@ericsson.com>
Simon Marchi <simon.marchi@ericsson.com> writes:
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-record-changed.exp: Adjust =record-started output
> matching.
We need to update gdb.mi/mi-reverse.exp too. Patch below does it.
Patch is pushed in.
--
Yao (齐尧)
From 647c264cb2c60c90ee2d09edb6bd001ff357306d Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Tue, 5 Jul 2016 14:46:21 +0100
Subject: [PATCH] Fix fail in gdb.mi/mi-reverse.exp
Commit 38b022b4452f996fb5a8598f80d850b594621bcf adds "method" and
"format" fields in =record-started, but doesn't update test case
gdb.mi/mi-reverse.exp, so it causes the fail like this,
PASS: gdb.mi/mi-reverse.exp: mi runto main
Expecting: ^(-interpreter-exec console record[^M
]+)?(=record-started,thread-group="i1"^M
\^done[^M
]+[(]gdb[)] ^M
[ ]*)
-interpreter-exec console record^M
=record-started,thread-group="i1",method="full"^M
^done^M
(gdb) ^M
FAIL: gdb.mi/mi-reverse.exp: Turn on process record
and regression was found by buildbot too
https://sourceware.org/ml/gdb-testers/2016-q2/msg04492.html
gdb/testsuite:
2016-07-05 Yao Qi <yao.qi@linaro.org>
* gdb.mi/mi-reverse.exp: Match =record-started output.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index bcbffaa..be0cf9d 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2016-07-05 Yao Qi <yao.qi@linaro.org>
+
+ * gdb.mi/mi-reverse.exp: Match =record-started output.
+
2016-07-01 Pedro Alves <palves@redhat.com>
* gdb.base/jit-reader.exp (info_registers_current_frame): New
diff --git a/gdb/testsuite/gdb.mi/mi-reverse.exp b/gdb/testsuite/gdb.mi/mi-reverse.exp
index d8f3844..5afeece 100644
--- a/gdb/testsuite/gdb.mi/mi-reverse.exp
+++ b/gdb/testsuite/gdb.mi/mi-reverse.exp
@@ -51,7 +51,7 @@ mi_run_to_main
if [supports_process_record] {
# Activate process record/replay
if [mi_gdb_test "-interpreter-exec console record" \
- "=record-started,thread-group=\"i1\"\r\n\\^done" \
+ "=record-started,thread-group=\"i1\",method=\"full\"\r\n\\^done" \
"Turn on process record"] {
warning "Fail to activate process record/replay, tests in this group will not be performed.\n"
return -1