This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/3] Fake VFORK_DONE events on FreeBSD


On 06/29/2016 12:00 AM, John Baldwin wrote:
> The FreeBSD native targets do not report a VFORK_DONE event at
> all currently.  FreeBSD's ptrace doesn't currently report an event
> when the vfork parent resumes, so this fixes the native targets to
> report a fake event after a sleep similar to the approach used on
> Linux.  While here I noticed that I botched the 'detach_fork' support
> in the original fork tracing patches, so I fixed that as well.
> 
> I am working on adding a new ptrace event to report a real vfork
> done event to FreeBSD.  Once that is merged to FreeBSD I will post
> a patch for gdb to use that when available instead.

LGTM.

- There's a tiny typo in the commit log of patch 1: "true.x".

- I suggest removing the reference to linux-nat.c in the comment in
  patch #3, because that workaround may be removed soon.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]