This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix implicit conversion warning produced by clang
- From: Taras Tsugrii <ttsugrii at fb dot com>
- To: gdb-patches at sourceware dot org
- Cc: Taras Tsugrii <ttsugrii at fb dot com>
- Date: Tue, 14 Jun 2016 10:55:42 -0700
- Subject: [PATCH] Fix implicit conversion warning produced by clang
- Authentication-results: sourceware.org; auth=none
When compiling with clang, which is part of Xcode 7.3, following warnings
are emitted:
objcopy.c:224:50: error: implicit conversion from enumeration type 'enum bfd_link_elf_stt_common' to different enumeration type 'enum bfd_link_discard' [-Werror,-Wenum-conversion]
static enum bfd_link_discard do_elf_stt_common = unchanged;
~~~~~~~~~~~~~~~~~ ^~~~~~~~~
objcopy.c:4290:26: error: implicit conversion from enumeration type 'enum bfd_link_elf_stt_common' to different enumeration type 'enum bfd_link_discard' [-Werror,-Wenum-conversion]
do_elf_stt_common = elf_stt_common;
~ ^~~~~~~~~~~~~~
objcopy.c:4292:26: error: implicit conversion from enumeration type 'enum bfd_link_elf_stt_common' to different enumeration type 'enum bfd_link_discard' [-Werror,-Wenum-conversion]
do_elf_stt_common = no_elf_stt_common;
~ ^~~~~~~~~~~~~~~~~
3 errors generated.
This is risky, since essentially there is a coupling between 2 different
enum orderings. Also since by default warnings are promoted to errors
it breaks default build.
To reproduce: ./configure && make
Verified by: ./configure && make # above warnings disappear
---
binutils/ChangeLog | 4 ++++
binutils/objcopy.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index ff8161a..08be889 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,7 @@
+2016-06-14 Taras Tsugrii <taras.tsugriy@gmail.com>
+
+ * objcopy.c: Fix clang implicit conversion warning.
+
2016-06-14 Alan Modra <amodra@gmail.com>
* ar.c: Expand uses of bfd_my_archive.
diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 06fcea3..76170cb 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -221,7 +221,7 @@ static enum
} do_debug_sections = nothing;
/* Whether to generate ELF common symbols with the STT_COMMON type. */
-static enum bfd_link_discard do_elf_stt_common = unchanged;
+static enum bfd_link_elf_stt_common do_elf_stt_common = unchanged;
/* Whether to change the leading character in symbol names. */
static bfd_boolean change_leading_char = FALSE;
--
2.8.0-rc2