This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: Fix assertion on replace_types()
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 13 Jun 2016 11:21:01 +0100
- Subject: Re: RFA: Fix assertion on replace_types()
- Authentication-results: sourceware.org; auth=none
- References: <87eg812zps dot fsf at redhat dot com>
On Mon, Jun 13, 2016 at 10:41 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi Guys,
>
> Compiling GDB with gcc version 6.1.1 from the about to be released
> Fedora 24 produces a warning/error about a redundant comparison in
> gdbtypes.c:replace_types(). The fix appears obvious to me, but since
> I am not a regular contributor, I thought that I had better check here
> first.
>
> OK to apply ?
Yes, it is OK. The comments say two types should be in the same objfile,
so your fix is right to me.
--
Yao (éå)