This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH] Add method/format information to =record-started
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 6 Jun 2016 14:02:36 +0000
- Subject: RE: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220 dot 22286-1-simon dot marchi at ericsson dot com> <A78C989F6D9628469189715575E55B23332EAEF5 at IRSMSX104 dot ger dot corp dot intel dot com> <57557571 dot 7040200 at ericsson dot com> <A78C989F6D9628469189715575E55B23332EB299 at IRSMSX104 dot ger dot corp dot intel dot com> <57557D26 dot 2080009 at ericsson dot com> <A78C989F6D9628469189715575E55B23332EB309 at IRSMSX104 dot ger dot corp dot intel dot com> <57557F4D dot 8020409 at ericsson dot com>
> -----Original Message-----
> From: Simon Marchi [mailto:simon.marchi@ericsson.com]
> Sent: Monday, June 6, 2016 3:49 PM
> To: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH] Add method/format information to =record-started
> From ce80ad77f163700e51c1e640ceb933b33ca1d280 Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Mon, 30 May 2016 17:29:39 -0400
> Subject: [PATCH] Add method/format information to =record-started
>
> Eclipse CDT now supports enabling execution recording using two methods
> (full and btrace) and both formats for btrace (bts and pt). In the
> event that recording is enabled behind the back of the GUI (by the user
> on the command line, or a script), we need to know which method/format
> are being used, so it can be correctly reflected in the interface. This
> patch adds this information to the =record-started async record.
>
> Before:
>
> =record-started,thread-group="i1"
>
> After:
>
> =record-started,thread-group="i1",method="btrace",format="bts"
> =record-started,thread-group="i1",method="btrace",format="pt"
> =record-started,thread-group="i1",method="full"
>
> The "format" field is only present when the current method supports
> multiple formats (only the btrace method as of now).
The btrace bits look good to me.
I'm wondering if we want the short or the long form of the format. If we
expect MI front-ends to just print it as-is, the long form may be more useful.
That's also what's printed by "info record". I'm fine either way.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928