This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add method/format information to =record-started
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 6 Jun 2016 09:24:34 -0400
- Subject: Re: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220 dot 22286-1-simon dot marchi at ericsson dot com> <A78C989F6D9628469189715575E55B23332EAEF5 at IRSMSX104 dot ger dot corp dot intel dot com> <86ziqywju7 dot fsf at gmail dot com>
On 16-06-06 09:03 AM, Yao Qi wrote:
> "Metzger, Markus T" <markus.t.metzger@intel.com> writes:
>
> Hi Markus,
> Thanks for reviewing the patch....
>
>>> + if (format != NULL)
>>> + {
>>
>> Do we really need braces, here...
>>
>
> Yes, two or more lines in code should be wrapped in braces.
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
Just to be clear, the inner if/else doesn't need them, but the outer one does.
Here's the result:
if (started)
{
if (format != NULL)
fprintf_unfiltered (
mi->event_channel,
"record-started,thread-group=\"i%d\",method=\"%s\",format=\"%s\"",
inferior->num, method, format);
else
fprintf_unfiltered (
mi->event_channel,
"record-started,thread-group=\"i%d\",method=\"%s\"",
inferior->num, method);
}
else
fprintf_unfiltered (mi->event_channel,
"record-stopped,thread-group=\"i%d\"", inferior->num);