This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix PR python/18984
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 2 Jun 2016 11:22:15 -0700
- Subject: Re: [RFA] Fix PR python/18984
- Authentication-results: sourceware.org; auth=none
- References: <1463614581-18216-1-git-send-email-tom at tromey dot com> <87shwvwjoq dot fsf at tromey dot com>
Hey Tom,
> Tom> This fixes PR python/18984.
> Tom> The bug is that gdbpy_solib_name uses GDB_PY_LL_ARG, whereas it should
> Tom> use GDB_PY_LLU_ARG to avoid overflow.
>
> Tom> Built and tested on x86-64 Fedora 23.
>
> Tom> 2016-05-18 Tom Tromey <tom@tromey.com>
>
> Tom> PR python/18984:
> Tom> * python/python.c (gdbpy_solib_name): Use GDB_PY_LLU_ARG.
>
> Ping.
>
> This one bit me again today, and the fix is particularly simple.
Sorry about the delay. The code patch looks good to me. For the testcase
patch, you said you'd be adjusting it for Python 3 as well? Just for
the avoidance of doubt, you're pre-approved on that as well. If there
are comments on it, we can address those later, as it wouldn't break
GDB anyways.
Thanks!
--
Joel