This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] infcmd, btrace: fix crash in 'finish' for tailcall-only frames
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 01 Jun 2016 09:51:02 +0100
- Subject: Re: [PATCH] infcmd, btrace: fix crash in 'finish' for tailcall-only frames
- Authentication-results: sourceware.org; auth=none
- References: <1464680165-29696-1-git-send-email-markus dot t dot metzger at intel dot com>
Markus Metzger <markus.t.metzger@intel.com> writes:
Patch is good to me, nits on code format,
> + do {
"{" should be in the new line.
> + start = frame;
> +
> + frame = skip_tailcall_frames (frame);
> + if (frame == NULL)
> + break;
> +
> + frame = skip_unwritable_frames (frame);
> + if (frame == NULL)
> + break;
> + } while (start != frame);
"while" should be in the new line too. The format is documented in
https://www.gnu.org/prep/standards/standards.html#Writing-C
--
Yao (éå)