This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] New test case gdb.trace/signal.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Apr 2016 13:57:32 +0100
- Subject: Re: [PATCH 1/7] New test case gdb.trace/signal.exp
- Authentication-results: sourceware.org; auth=none
- References: <1458749384-19793-1-git-send-email-yao dot qi at linaro dot org> <1458749384-19793-2-git-send-email-yao dot qi at linaro dot org> <5707E1CC dot 2010609 at redhat dot com> <86a8l0leqy dot fsf at gmail dot com> <570BAECD dot 30508 at redhat dot com> <86inz9j4oo dot fsf at gmail dot com>
On 04/22/2016 11:52 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>>> +# Record the hit times of each tracepoint in this array.
>>> +array set tracepoint_hits { }
>>> +
>>> +set test "tfind 0"
>>> +gdb_test_multiple $test $test {
>>
>> Why do we need this separate "tfind 0" step? I'd think the
>> "tfind" loop below would be sufficient?
>
> I don't know the first "tfind" can find the first snapshot , and I think
> "tfind 0" should be the first one in all other "tfind X" commands.
>
> The usage like this is not documented.
I didn't know it wasn't documented. I think the testsuite
uses it extensively.
> In current doc:
>
> tfind
>
> No argument means find the next trace snapshot.
>
> We probably need to change the doc to
>
> No argument means find the next trace snapshot or find the first
> one if no trace snapshot is selected.
Yeah.
Thanks,
Pedro Alves