This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Set bp_tgt->reqstd_address and bp_tgt->placed_size in record_full_insert_breakpoint


Luis Machado <lgustavo@codesourcery.com> writes:

>> +      CORE_ADDR addr = bp_tgt->reqstd_address;
>
> Do we really need to get this initialized?
>

Yes, 'addr' is passed to gdbarch_breakpoint_from_pc below.

>> +      int bplen;
>> +
>> +      gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
>> +
>> +      bp_tgt->placed_address = addr;
>> +      bp_tgt->placed_size = bplen;

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]