This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Set bp_tgt->reqstd_address and bp_tgt->placed_size in record_full_insert_breakpoint
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 06 Apr 2016 09:36:19 +0100
- Subject: Re: [PATCH 1/2] Set bp_tgt->reqstd_address and bp_tgt->placed_size in record_full_insert_breakpoint
- Authentication-results: sourceware.org; auth=none
- References: <1459759138-1494-1-git-send-email-yao dot qi at linaro dot org> <1459759138-1494-2-git-send-email-yao dot qi at linaro dot org> <5704255C dot 4080402 at codesourcery dot com>
Luis Machado <lgustavo@codesourcery.com> writes:
>> + CORE_ADDR addr = bp_tgt->reqstd_address;
>
> Do we really need to get this initialized?
>
Yes, 'addr' is passed to gdbarch_breakpoint_from_pc below.
>> + int bplen;
>> +
>> + gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
>> +
>> + bp_tgt->placed_address = addr;
>> + bp_tgt->placed_size = bplen;
--
Yao (éå)