Re: [PATCH 1/2] Set bp_tgt->reqstd_address and bp_tgt->placed_size in record_full_insert_breakpoint

[Luis Machado <lgustavo at codesourcery dot com>]

On 04/04/2016 03:38 AM, Yao Qi wrote:
> I notice that bp_tgt won't be fully initialized if to_insert_breakpoint
> isn't called in record_full_insert_breakpoint, and bp_tgt->reqstd_address
> is zero, so an entry is added to record_full_breakpoints, but its address
> is zero, which is wrong.  This patch is to call gdbarch_breakpoint_from_pc
> in the else branch to set bp_tgt->reqstd_address and bp_tgt->placed_size.
>
> gdb:
>
> 2016-04-04  Yao Qi  <yao.qi@linaro.org>
>
> 	* record-full.c (record_full_insert_breakpoint): Set
> 	bp_tgt->reqstd_address and bp_tgt->placed_size.
> ---
>   gdb/record-full.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/gdb/record-full.c b/gdb/record-full.c
> index f6023bf..066a8e7 100644
> --- a/gdb/record-full.c
> +++ b/gdb/record-full.c
> @@ -1670,6 +1670,16 @@ record_full_insert_breakpoint (struct target_ops *ops,
>
>         in_target_beneath = 1;
>       }
> +  else
> +    {
> +      CORE_ADDR addr = bp_tgt->reqstd_address;

Do we really need to get this initialized?

> +      int bplen;
> +
> +      gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
> +
> +      bp_tgt->placed_address = addr;
> +      bp_tgt->placed_size = bplen;
> +    }
>
>     bp = XNEW (struct record_full_breakpoint);
>     bp->addr = bp_tgt->placed_address;

Otherwise looks good.