This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] testsuite: Update py-mi-objfile to expect console format print

> On 04/05/2016 11:14 AM, Catalin Udma wrote:
> > --- a/gdb/testsuite/gdb.python/
> > +++ b/gdb/testsuite/gdb.python/
> > @@ -24,4 +24,4 @@ import gdb
> >  gdb.execute("set width 101", to_string=True)
> >  # And finally a command that will use the original MI stream, which in a
> >  # buggy gdb will use just-freed data.
> > -gdb.execute("list")
> > +gdb.execute("list main")
> Do the comments in the test still make sense?
> From the comment, sounds like the test might no longer be covering
> what it intended?  I.e. do we "use the original MI stream" ?
> Thanks,
> Pedro Alves

[Catalin Udma] Indeed, the original crash is no longer reproducible: I manually reverted the fixes
for that crash (gdb/cli/cli-logging.c, gdb/mi/mi-out.c) and the crash is not reproducible anymore 
when running py-mi-objfile.exp.
It reproduces if I revert also this patch " python: Use console format for output of gdb.execute command"

Updating the comments would be enough and let the test validate the same scenario? 

"+# And finally a command that will use the console stream without redirection" ?

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]