This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v2] python: Use console format for output of gdb.execute command
- From: Catalin-Dan Udma <catalin-dan dot udma at nxp dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, Catalin Udma <catalin dot udma at freescale dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 5 Apr 2016 09:52:44 +0000
- Subject: RE: [PATCH v2] python: Use console format for output of gdb.execute command
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=nxp.com;
- References: <1459420984-6582-1-git-send-email-catalin dot udma at freescale dot com> <5702E514 dot 7000608 at ericsson dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Simon Marchi
> On 16-03-31 06:43 AM, Catalin Udma wrote:
> > When gdb is started in MI mode, the output of gdb.execute
> > command is in MI-format in case when it is executed from python stop
> > handler while for all other cases the output is in console-format.
> >
> > To assure consistent output format, this is fixed by using the console
> > format for all python gdb command executions.
> >
> > PR python/19743
> >
> > gdb/ChangeLog:
> > 2016-03-31 Catalin Udma <catalin.udma@freescale.com>
> >
> > PR python/19743
> > * python/python.c (execute_gdb_command): Use console uiout
> > when executing gdb command.
> > * utils.c (restore_ui_out_closure): New structure.
> > (do_restore_ui_out): New function.
> > (make_cleanup_restore_ui_out): Likewise.
> > * utils.h (make_cleanup_restore_ui_out): Declare.
> >
> > gdb/testsuite/ChangeLog:
> > 2016-03-31 Catalin Udma <catalin.udma@freescale.com>
> >
> > PR python/19743
> > * gdb.python/py-mi-events-gdb.py: New file.
> > * gdb.python/py-mi-events.c: New file.
> > * gdb.python/py-mi-events.exp: New file.
> >
> > Signed-off-by: Catalin Udma <catalin.udma@freescale.com>
> > ---
> Hi Catalin,
>
> I think that gdb.python/py-mi-objfile.exp started failing with this commit.
> Buildbot seems to
> agree:
>
> http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-
> m64/.git/tree/?id=9473ce97ff66c5f312080c983992b4581accef94
>
> I haven't debugged it yet, so I can't tell whether it's gdb or the test who's at
> fault.
>
> Would you have time to take a look?
>
> Thanks,
>
> Simon
[Catalin Udma] The py-mi-objfile.exp test needs to be fixed. This is exactly what my patch
is trying to fix:
- when the python script is called from command line, it prints the "list" command in console format
- when the python script is called as an event triggered by symbol loading, the unpatched gdb would
prints the "list" command in MI format. With my patch, the output is consistent and the python
script would print in console format.
I'll send a patch updating the py-mi-objfile.exp test to expect the script printing in console format.
Regards,
Catalin