This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Add arm epilogue unwinder
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 29 Mar 2016 18:00:16 +0100
- Subject: Re: [PATCH 2/2] Add arm epilogue unwinder
- Authentication-results: sourceware.org; auth=none
- References: <1458830369-1974-1-git-send-email-yao dot qi at linaro dot org> <1458830369-1974-3-git-send-email-yao dot qi at linaro dot org>
LGTM. A couple super minor nits below.
On 03/24/2016 02:39 PM, Yao Qi wrote:
+static struct arm_prologue_cache *
+arm_make_epilogue_frame_cache (struct frame_info *this_frame)
+{
Missing intro comments in several functions.
+ pc = get_frame_pc (this_frame);
+ func = get_frame_func (this_frame);
+ if (!func)
func == NULL.
Thanks,
Pedro Alves