This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6] Enable tracing of pseudo-registers on ARM
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org, qiyaoltc at gmail dot com
- Date: Thu, 25 Feb 2016 17:59:11 +0000
- Subject: Re: [PATCH v6] Enable tracing of pseudo-registers on ARM
- Authentication-results: sourceware.org; auth=none
- References: <861t81cc2c dot fsf at gmail dot com> <1456414378-1918-1-git-send-email-antoine dot tremblay at ericsson dot com>
On 02/25/2016 03:32 PM, Antoine Tremblay wrote:
> In this v6:
> * use https://sourceware.org/ml/gdb-patches/2016-02/msg00786.html to map
> registers to remote registers. (This is already in master)
> * Fix test changelog
> * Test is already renamed, update patch.
> -
> This patch implements the ax_pseudo_register_push_stack and
> ax_pseudo_register_collect gdbarch functions so that a pseudo-register can
> be traced.
>
FAOD, I'm happy with this version, if Yao is happy.
> dummy (void)
> @@ -37,6 +41,7 @@ main (void)
> {
> /* Strictly speaking, it should be ymm15 (xmm15 is 128-bit), but gcc older
> than 4.9 doesn't recognize "ymm15" as a valid register name. */
> +#if (defined __x86_64__)
The comment should be within the #if.
Thanks,
Pedro Alves