This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, v3] Expect SI_KERNEL or TRAP_BRKPT si_code values for MIPS breakpoint traps
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Cc: macro at linux-mips dot org
- Date: Mon, 22 Feb 2016 22:41:33 +0000
- Subject: Re: [PATCH, v3] Expect SI_KERNEL or TRAP_BRKPT si_code values for MIPS breakpoint traps
- Authentication-results: sourceware.org; auth=none
- References: <1456179628-14249-1-git-send-email-lgustavo at codesourcery dot com>
On 02/22/2016 10:20 PM, Luis Machado wrote:
> diff --git a/gdb/nat/linux-ptrace.h b/gdb/nat/linux-ptrace.h
> index ba58717..72b32b1 100644
> --- a/gdb/nat/linux-ptrace.h
> +++ b/gdb/nat/linux-ptrace.h
> @@ -140,11 +140,16 @@ struct buffer;
> in SPU code on a Cell/B.E. However, SI_KERNEL is never seen
> on a SIGTRAP for any other reason.
>
> + The MIPS kernel uses the default si_code of SI_KERNEL for software
> + breakpoints, hardware watchpoints and SIGTRAP's in general.
If we get this for both software breakpoints and hardware watchpoints,
then it seems to me that this change still leaves watchpoints broken,
as I can't see how check_stopped_by_watchpoint is reached, in either
gdb/linux-nat.c or gdbserver/linux-low.c.
Also, "and SIGTRAP's in general." seems wrong. I hope that that's
not the case for user-sent SIGTRAPs?
Thanks,
Pedro Alves