This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 02/10] Garbage collect window_hook
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 18 Feb 2016 16:55:26 -0500
- Subject: Re: [PATCH 02/10] Garbage collect window_hook
- Authentication-results: sourceware.org; auth=none
- References: <1455817236-13642-1-git-send-email-palves at redhat dot com> <1455817236-13642-3-git-send-email-palves at redhat dot com>
On Thursday, February 18 2016, Pedro Alves wrote:
> I checked, and Insight doesn't set this.
>
> gdb/ChangeLog:
> 2016-02-18 Pedro Alves <palves@redhat.com>
>
> * top.c (window_hook): Delete.
> (command_loop): Remove references to window_hook.
> ---
> gdb/top.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/gdb/top.c b/gdb/top.c
> index ed200ba..b5ee4af 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -124,12 +124,6 @@ char *current_directory;
> /* The directory name is actually stored here (usually). */
> char gdb_dirbuf[1024];
>
> -/* Function to call before reading a command, if nonzero.
> - The function receives two args: an input stream,
> - and a prompt string. */
> -
> -void (*window_hook) (FILE *, char *);
> -
> /* Buffer used for reading command lines, and the size
> allocated for it so far. */
>
> @@ -545,9 +539,6 @@ command_loop (void)
>
> while (instream && !feof (instream))
> {
> - if (window_hook && instream == stdin)
> - (*window_hook) (instream, get_prompt ());
> -
> clear_quit_flag ();
> if (instream == stdin)
> reinitialize_more_filter ();
> --
> 1.9.3
LGTM.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/