This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [D] Add support for printing D types.
- From: Iain Buclaw <ibuclaw at gdcproject dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 18 Feb 2016 22:10:04 +0100
- Subject: Re: [PATCH] [D] Add support for printing D types.
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+ddgQfb-0w5cY8Nrt8vvFM1nnTnn1yGJWiWz5sAtnv5zQ at mail dot gmail dot com> <56C49BE1 dot 2020204 at redhat dot com>
On 17 February 2016 at 17:12, Pedro Alves <palves@redhat.com> wrote:
> Hi Iain,
>
> On 01/30/2016 04:29 PM, Iain Buclaw wrote:
>
>> gdb/ChangeLog:
>>
>
>> * d-lang.c (d_language_defn): Change c_print_type to d_print_type.
>> * d-lang.h (d_print_type): New declaration.
>> * d-typeprint.c: New file.
>>
>
> These bits you can clearly self approve.
>
OK, however, I do try to hold back on bigger changes, as there may
have been something i overlooked.
>
>> * Makefile.in (SFILES): Add d-typeprint.c
>> (COMMON_OBJS): Add d-typeprint.o
>> * dwarf2read.c (read_structure_type): Set TYPE_DECLARED_CLASS also for
>> classes in D language.
>
> FAOD, these bits are OK.
>
Thanks.
>
>> gdb/testsuite/ChangeLog:
>>
>> * typeprint.S: New file.
>> * typeprint.exp: New file.
>
> But these can be written in D now, right?
>
I guess so, would this be the preferred method for tests that use simple code?
I will redo this patch anyway, I noticed it's an old version with a
FIXME that I forgot to remove.
Regards,
Iain.