Re: [PATCH, doc RFA] Add "skip regexp"

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 17 Feb 2016 01:07:38 +0000
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org
> 
> Eli: Heads up, rewritten docs, needing re-approval.

Thanks for the heads-up.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -127,6 +127,14 @@ show max-value-size
>     allocate for value contents.  Prevents incorrect programs from
>     causing GDB to allocate overly large buffers.  Default is 64k.
> 
> +skip -file file
> +skip -gfile file-glob-pattern
> +skip -function function
> +skip -rfunction regular-expression
> +  A generalized form of the skip command, with new support for
> +  glob-style file names and regular expressions for function names.
> +  Additionally, a file spec and a function spec may now be combined.
> +

This part is OK.

> +@item -gfile @var{file-glob-pattern}
> +@itemx -gfi @var{file-glob-pattern}
> +Functions in files matching @var{file-glob-pattern} will be skipped
> +over when stepping.
> +
> +@smallexample
> +(gdb) skip -gfi utils/*.c
> +@end smallexample

Is there a way to protect wildcard characters?  If so, I think we
should mention it.

> +For example, there is generally no need to step into C++ std::string

C@t{++}, and "std::string" should be in @code.

Also, this description should have a couple of @cindex entries, as
readers are likely to look for it without remembering that the
command's name is "skip".

The documentation is OK with those fixed.

Thanks.