This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Fri, 12 Feb 2016 11:15:11 +0000
- Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned
- Authentication-results: sourceware.org; auth=none
- References: <1455029644-6197-1-git-send-email-yao dot qi at linaro dot org> <86egckqztq dot fsf at gmail dot com> <56BB6ADB dot 6070909 at redhat dot com> <86a8n8qxyp dot fsf at gmail dot com> <56BB7512 dot 2030507 at redhat dot com> <8660xvr1wr dot fsf at gmail dot com> <56BC829B dot 8060102 at redhat dot com> <864mdfp9b3 dot fsf at gmail dot com> <56BCAE02 dot 7030803 at redhat dot com> <56BCBE08 dot 6040306 at gmail dot com> <56BCC3B1 dot 5090400 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
> I just don't see what the worry is. OTOH, sharing the routines
> would pave to way to share more, and have one less diverging detail
> to worry about, avoiding proliferation of "bridging" interfaces like
> regcache_raw_read_unsigned or the need to hook in more entry points
> to get_next_pcs and whatever else we put in shared code areas.
I don't worry about the code sharing. I am OK with your patches moving
bfd_endian to a separate header and fix the issue in
regcache_raw_read_unsigned with extract_unsigned_integer.
--
Yao (éå)