This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Pedro Alves <palves at redhat dot com>
Cc: simon dot marchi at ericsson dot com, gdb-patches at sourceware dot org, sergiodj at redhat dot com
Date: Fri, 12 Feb 2016 11:21:47 +0100
Subject: Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.
Authentication-results: sourceware.org; auth=none
References: <56BDAEA4 dot 1030500 at redhat dot com> <1455271799-20446-1-git-send-email-koriakin at 0x04 dot net> <56BDB1B9 dot 8070909 at redhat dot com>

On 12/02/16 11:19, Pedro Alves wrote:

On 02/12/2016 10:09 AM, Marcin KoÅcielnicki wrote:

Introduced by 18d3cec54e1b4fce278dba436484846f8048d7d6.

gdb/ChangeLog:

	* xml-tdesc.c (target_fetch_description_xml): Warn and return NULL
	when built without expat.
---
How about that?


There's a standard CL format for conditionally compiled code:

	* xml-tdesc.c (target_fetch_description_xml) [!HAVE_LIBEXPAT]: Warn
	and return NULL.

OK with that change.

Thanks,
Pedro Alves


Thanks, pushed.

References:
- Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.
  - From: Pedro Alves
- [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.
  - From: Marcin KoÅcielnicki
- Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]