Re: [PATCH] supports IPv6 only remote target

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Tue, 9 Feb 2016 22:49:57 +0900
> From: Tsutomu Seki <sekiriki@gmail.com>
> 
> +Numerical @acronym{IPv6} address must be enclosed in square brackets.
> +For example, to connect to port 2159 of a target which has IPv6
> +link-local address fe80::1 on eth1:

Please use @code with the address string fe80::1.

> +
> +@smallexample
> +target remote [fe80::1%eth1]:2159
> +@end smallexample

This example seems to imply that more than just taking brackets is
required.  Should we tell more about that?

> +The service name is default to ``gdbremote''. If the service name is

Please use

  The service name defaults to @code{"gdbremote"}

Also, we leave 2 spaces between sentences.

> +present in service list (e.g.@: @file{/etc/services} on @sc{gnu}/Linux
> +systems), and target is listening on assigned port, you can omit the

I guess you mean "on the port assigned to that service", yes?

The documentation parts are OK with these fixed.

> --- a/gdb/ser-tcp.c
> +++ b/gdb/ser-tcp.c
> @@ -39,6 +39,7 @@
> 
>  #ifdef USE_WIN32API
>  #include <winsock2.h>
> +#include <wspiapi.h>

I think this will break the build with mingw.org's MinGW.  It doesn't
have wspiapi.h, AFAIK.  What exactly is needed from that header?

Thanks.