This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 9 Feb 2016 15:58:19 +0400
- Subject: Re: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames
- Authentication-results: sourceware.org; auth=none
- References: <1454681922-2228-1-git-send-email-markus dot t dot metzger at intel dot com> <1454681922-2228-2-git-send-email-markus dot t dot metzger at intel dot com> <20160207130057 dot GE20874 at adacore dot com> <A78C989F6D9628469189715575E55B233325F370 at IRSMSX104 dot ger dot corp dot intel dot com> <56B9D08F dot 6060507 at redhat dot com>
> > I modified an existing test case to cover the changes. GDB dies with the modified
> > test and without the changes to skip_tailcall_frames. This also showed another place
> > where we want to use get_prev_frame_always.
> >
> > Here's the modified version of this patch:
>
> Thanks. Could you do the limiting test in e.g., gdb.base/finish.exp
> and gdb.base/return.exp, so that it'd be covered on all archs?
I was going to ask the very same :-). The fact that adding your test
showed we missed a spot raised the question as to how much of the
initial patch we were testing :).
--
Joel