This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] remote.c: Cleanup unused variables
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 8 Feb 2016 13:02:21 -0500
- Subject: Re: [PATCH] remote.c: Cleanup unused variables
- Authentication-results: sourceware.org; auth=none
- References: <1454007885-13491-1-git-send-email-simon dot marchi at ericsson dot com> <20160207124304 dot GB20874 at adacore dot com>
On 16-02-07 07:43 AM, Joel Brobecker wrote:
>> I built remote.c with -Wunused, to check a function I was working on,
>> turns out there is a bunch of unused variables.
>>
>> gdb/ChangeLog:
>>
>> * remote.c (remote_register_number_and_offset): Remove unused
>> variable(s).
>> (remote_thread_always_alive): Likewise.
>> (remote_update_thread_list): Likewise.
>> (process_initial_stop_replies): Likewise.
>> (remote_start_remote): Likewise.
>> (remote_check_symbols): Likewise.
>> (discard_pending_stop_replies): Likewise.
>> (process_stop_reply): Likewise.
>> (putpkt_binary): Likewise.
>> (getpkt): Likewise.
>> (remote_add_target_side_condition): Likewise.
>> (remote_insert_breakpoint): Likewise.
>> (remote_supports_stopped_by_sw_breakpoint): Likewise.
>> (remote_supports_stopped_by_hw_breakpoint): Likewise.
>> (remote_xfer_partial): Likewise.
>> (remote_read_btrace): Likewise.
>> (remote_async_serial_handler): Likewise.
>> (remote_thread_events): Likewise.
>> (_initialize_remote): Likewise.
>
> This looks good to me.
>
> Thanks for doing this,
Thanks, pushed!