This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Handle loading improper core files gracefully in the mips backend.
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, "Maciej W. Rozycki" <macro at imgtec dot com>
- Cc: gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com
- Date: Tue, 02 Feb 2016 14:22:44 +0000
- Subject: Re: [PATCH] Handle loading improper core files gracefully in the mips backend.
- Authentication-results: sourceware.org; auth=none
- References: <1452277948-25292-1-git-send-email-lgustavo at codesourcery dot com> <alpine dot DEB dot 2 dot 00 dot 1601090245560 dot 5958 at tp dot orcam dot me dot uk> <5693CE90 dot 1060709 at codesourcery dot com> <5694F5BC dot 3050904 at redhat dot com> <5694FEB8 dot 10406 at codesourcery dot com> <56950952 dot 2030504 at redhat dot com> <56951F29 dot 7070000 at codesourcery dot com> <alpine dot DEB dot 2 dot 00 dot 1601121710020 dot 5958 at tp dot orcam dot me dot uk> <56B0A809 dot 6070101 at codesourcery dot com> <56B0BAEA dot 7 at redhat dot com>
On 02/02/2016 02:19 PM, Pedro Alves wrote:
> On 02/02/2016 12:58 PM, Luis Machado wrote:
> Did you try to trigger the assertion by loading a 32-bit MIPS binary
> into gdb, and playing with "set mips abi n64/o64...", "set mipsfpu",
> etc?
>
> I think that adding a test to the testsuite that iterates through all
> the possible combinations just to make sure gdb doesn't crash
> would be great, and also show that the patch stands on its own
> as well, irrespective of the bfd arch compatibility issues.
TBC, I meant, the original patch that checked unsuitable ABI/ISA
combinations.
Thanks,
Pedro Alves