This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Limit breakpoint re-set to the current program space
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 19 Jan 2016 12:33:54 +0000
- Subject: Re: [PATCH] Limit breakpoint re-set to the current program space
- Authentication-results: sourceware.org; auth=none
- References: <1452645298-19600-1-git-send-email-palves at redhat dot com> <569D6EDA dot 2080804 at redhat dot com>
On 01/18/2016 11:01 PM, Keith Seitz wrote:
> On 01/12/2016 04:34 PM, Pedro Alves wrote:
>> Currently, we always re-set all locations of all breakpoints. This
>> commit makes us re-set only locations of the current program space.
>
> I'll come right out and say it: Damn! Why didn't I think of that?
>
> You are no doubt aware (but other readers may not be), I've delved into
> breakpoint_re_set optimization a bit, and published a branch and wiki
> page for the (in-progress) work I've done.
> [https://sourceware.org/gdb/wiki/BreakpointReset]
>
> Your approach here is pretty much identical to the approach I took on my
> breakpoint-reset project branch. So I cannot find any fault with that. ;-)
>
> Your implementation, on the other hand, is, well, at least as good. :-)
:-)
This patch doesn't handle limiting re-set to a single DSO, so there's
still scope to pick up things from your branch. I'm not sure we need
your caching mechanism, or whether my simpler breakpoint-location
hoisting bit is sufficient for that case, though. Whoever picks that
up next gets to figure it out. :-)
> Well done,
Thanks for taking a look! I pushed it in now.
Thanks,
Pedro Alves