This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD.
- From: John Baldwin <jhb at freebsd dot org>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Jan 2016 12:18:46 -0800
- Subject: Re: [PATCH v2 4/6] Use LWP IDs with ptrace register requests on FreeBSD.
- Authentication-results: sourceware.org; auth=none
- References: <1452721551-657-1-git-send-email-jhb at FreeBSD dot org> <1452721551-657-5-git-send-email-jhb at FreeBSD dot org> <5697B9B0 dot 1090705 at redhat dot com>
On Thursday, January 14, 2016 03:07:28 PM Pedro Alves wrote:
> [Dropping binutils.]
>
> On 01/13/2016 09:45 PM, John Baldwin wrote:
> > This allows gdb to fetch per-thread registers for multi-threaded FreeBSD
> > processes. NetBSD and OpenBSD also accept LWP IDs for ptrace requests
> > to fetch per-thread state.
>
> I'd prefer to make inf-ptrace.c:get_ptrace_pid extern and use
> it, instead of duplicating it multiple times.
This sounds good to me. Do you want me to use it in other places as well?
sparc-nat.c at least duplicates the same logic inline. amd64linux-nat.c
does as well. If so, would you rather that be a seperate patch (expose
get_ptrace_pid() and use it in existing targets) from this patch?
--
John Baldwin