This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [ARM] Make thumb2_breakpoint static again
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 14 Jan 2016 09:37:16 +0000
- Subject: Re: [PATCH] [ARM] Make thumb2_breakpoint static again
- Authentication-results: sourceware.org; auth=none
- References: <1452674732-9286-1-git-send-email-yao dot qi at linaro dot org> <56964C97 dot 6090505 at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>> gdb:
>>
>> 2016-01-13 Yao Qi <yao.qi@linaro.org>
>>
>> * arch/arm-get-next-pcs.c (arm_get_next_pcs_ctor): Change
>> argument arm_thumb2_breakpoint to has_thumb2_breakpoint.
>> (thumb_get_next_pcs_raw): Check has_thumb2_breakpoint
>> instead.
>> * arch/arm-get-next-pcs.h (struct arm_get_next_pcs)
>> <arm_thumb2_breakpoint>: Remove.
>> <has_thumb2_breakpoint>: New field.
>> (arm_get_next_pcs_ctor): Update declaration.
>> * arm-linux-tdep.c (arm_linux_software_single_step): Pass
>> 1 to arm_get_next_pcs_ctor.
>> * arm-tdep.c (arm_software_single_step): Pass 0 to
>> arm_get_next_pcs_ctor.
>>
>> gdb/gdbserver:
>>
>> 2016-01-13 Yao Qi <yao.qi@linaro.org>
>>
>> * linux-aarch32-low.c (thumb2_breakpoint): Make it static.
>> * linux-aarch32-low.h (thumb2_breakpoint): Remove declaration.
>> * linux-arm-low.c (arm_gdbserver_get_next_pcs): Pass 1 to
>> arm_get_next_pcs_ctor.
>
> LGTM.
Patch is pushed in.
--
Yao (éå)