This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] sim: h8300: move unused/buggy lregs array [committed]
- From: Mike Frysinger <vapier at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Date: Wed, 30 Dec 2015 03:31:41 -0500
- Subject: [PATCH] sim: h8300: move unused/buggy lregs array [committed]
- Authentication-results: sourceware.org; auth=none
This array isn't used anywhere, and the init phase actually corrupts
some memory because the array has 18 elements but tries to set the
19th (ZERO) position.
---
sim/h8300/ChangeLog | 5 +++++
sim/h8300/compile.c | 4 ----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/sim/h8300/ChangeLog b/sim/h8300/ChangeLog
index b4ad754..b293b29 100644
--- a/sim/h8300/ChangeLog
+++ b/sim/h8300/ChangeLog
@@ -1,5 +1,10 @@
2015-12-30 Mike Frysinger <vapier@gentoo.org>
+ * compile.c (lreg): Delete.
+ (init_pointers): Delete lreg assignments.
+
+2015-12-30 Mike Frysinger <vapier@gentoo.org>
+
* inst.h: Delete file.
* Makefile.in (compile.o): Delete rule.
diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c
index bc91725..beb2ab6 100644
--- a/sim/h8300/compile.c
+++ b/sim/h8300/compile.c
@@ -1251,7 +1251,6 @@ compile (SIM_DESC sd, int pc)
static unsigned char *breg[32];
static unsigned short *wreg[16];
-static unsigned int *lreg[18];
#define GET_B_REG(X) *(breg[X])
#define SET_B_REG(X, Y) (*(breg[X])) = (Y)
@@ -1828,11 +1827,8 @@ init_pointers (SIM_DESC sd)
sim_io_printf (sd, "init_pointers: internal error.\n");
h8_set_reg (sd, i, 0);
- lreg[i] = h8_get_reg_buf (sd) + i;
}
- /* Note: sim uses pseudo-register ZERO as a zero register. */
- lreg[ZERO_REGNUM] = h8_get_reg_buf (sd) + ZERO_REGNUM;
init_pointers_needed = 0;
/* Initialize the seg registers. */
--
2.6.2