This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC/commmit] [testsuite/Ada] stop using project files when building test programs
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 23 Dec 2015 15:30:17 +0000
- Subject: Re: [RFC/commmit] [testsuite/Ada] stop using project files when building test programs
- Authentication-results: sourceware.org; auth=none
- References: <1450798411-26617-1-git-send-email-brobecker at adacore dot com> <567A9FE6 dot 30504 at redhat dot com> <20151223133504 dot GB18676 at adacore dot com> <20151223144303 dot GC18676 at adacore dot com> <567ABC0C dot 3040204 at redhat dot com>
On 12/23/2015 03:21 PM, Pedro Alves wrote:
>> > --- a/gdb/testsuite/gdb.ada/cond_lang.exp
>> > +++ b/gdb/testsuite/gdb.ada/cond_lang.exp
>> > @@ -39,7 +39,7 @@ gdb_test "show lang" \
>> > # current language mode is auto, and the breakpoint is inside Ada code.
>> > set bp_location [gdb_get_line_number "STOP" ${testdir}/mixed.adb]
>> > gdb_test "break mixed.adb:${bp_location} if light = green" \
>> > - "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\."
>> > + "Breakpoint \[0-9\]* at .*: file (.*/)?mixed.adb, line \[0-9\]*\\."
> Isn't that the same as just:
>
> - "Breakpoint \[0-9\]* at .*: file .*/mixed.adb, line \[0-9\]*\\."
> + "Breakpoint \[0-9\]* at .*: file .*mixed.adb, line \[0-9\]*\\."
>
> ?
>
Huh, sorry, brain malfunction. My version would give out a spurious
PASS with foomixed.adb, yours wouldn't.
>> > gdb_test "continue" \
>> > - "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at .*/pck.adb:.*" \
>> > + "Breakpoint .*, pck\\.call_me \\(w=(w@entry=)?50\\) at (.*)?/pck.adb:.*" \
>> > "continue to call_me"
> Likewise, I think this is a no-op. Did you mean to put the / inside the
> parens like in the other case? If so I'd suggest:
This one still looks odd to me, though.
Thanks,
Pedro Alves