Re: find_and_open_source in symtab_to_fullname

[Yao Qi <qiyaoltc at gmail dot com>]

Yao Qi <qiyaoltc@gmail.com> writes:

> diff --git a/gdb/linespec.c b/gdb/linespec.c
> index b2233b9..ab77e7e 100644
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -1842,7 +1842,14 @@ create_sals_line_offset (struct linespec_state *self,
>        fullname = symtab_to_fullname (self->default_symtab);
>        VEC_pop (symtab_ptr, ls->file_symtabs);
>        VEC_free (symtab_ptr, ls->file_symtabs);
> -      ls->file_symtabs = collect_symtabs_from_filename (fullname);
> +
> +      if (IS_ABSOLUTE_PATH (fullname))
> +       {
> +         VEC_safe_push (symtab_ptr, ls->file_symtabs, self->default_symtab);
> +       }
> +      else
> +       ls->file_symtabs = collect_symtabs_from_filename (fullname);
> +
>        use_default = 1;
>      }

This patch causes a regression,

(gdb) break 37^M
No line 37 in the current file.^M
Make breakpoint pending on future shared library load? (y or [n]) n^M
(gdb) FAIL: gdb.base/expand-psymtabs.exp: Expand psymtabs (got interactive prompt)

looks more thoughts are needed here.

-- 
Yao (éå)