This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
- From: "Thomas Preud'homme" <thomas dot preudhomme at foss dot arm dot com>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 22 Dec 2015 10:55:38 +0800
- Subject: RE: [PATCH, ping1] Add missing expect for running a program with CLI jump
- Authentication-results: sourceware.org; auth=none
- References: <000101d13979$d1e0c610$75a25230$ at foss dot arm dot com> <20151218182252 dot GF29928 at adacore dot com> <002a01d13bd9$29442990$7bcc7cb0$ at foss dot arm dot com> <20151221110602 dot GA5564 at adacore dot com>
Done, thanks.
Best regards,
Thomas
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Joel Brobecker
> Sent: Monday, December 21, 2015 7:06 PM
> To: Thomas Preud'homme
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH, ping1] Add missing expect for running a program
> with CLI jump
>
> > I hope this time it's fine. I'm also adding it in attachment just in case.
> >
> > Best regards,
> >
> > Thomas
> >
> > diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-
> support.exp
> > index 0d17ecb..cc055f6 100644
> > --- a/gdb/testsuite/lib/mi-support.exp
> > +++ b/gdb/testsuite/lib/mi-support.exp
> > @@ -886,6 +886,9 @@ proc mi_run_cmd_full {use_mi_command args}
> {
> > # to better handle RUN.
> > send_gdb "jump *$start\n"
> > warning "Using CLI jump command, expect run-to-main FAIL"
> > + gdb_expect {
> > + -re "${run_match}&\"jump
> \\*${start}\\n\"\[\r\n\]+~\"Continuing at 0x\[0-9A-Fa-
> f\]+\\n.\"\[\r\n\]+\^running\[\r\n\]+\\*running,thread-
> id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {}
> > + }
> > return 0
> > }
>
> Thanks. LGTM, so go ahead and push.
>
> > > > > 2015-10-15 Thomas Preud'homme
> > > <thomas.preudhomme@arm.com>
> > > > >
> > > > > * lib/mi-support.exp (mi_run_cmd_full): Add an expect for
> the
> > > CLI
> > > > > jump
> > > > > case.
> > >
> > > I think the patch is good, but your mailer did some line folding.
> > > Can you resend?
> --
> Joel