This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v7.1 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>, <qiyaoltc at gmail dot com>
- Date: Thu, 17 Dec 2015 07:51:25 -0500
- Subject: Re: [PATCH v7.1 3/8] Use xml-syscall to compare syscall numbers in arm_linux_sigreturn_return-addr
- Authentication-results: sourceware.org; auth=none
- References: <56718BB5 dot 20508 at ericsson dot com> <1450283042-28746-1-git-send-email-antoine dot tremblay at ericsson dot com> <56728BA4 dot 9000709 at redhat dot com>
On 12/17/2015 05:17 AM, Pedro Alves wrote:
You also need a dummy version of the function under
#ifndef HAVE_LIBEXPAT
in order to avoid breaking the build when expat is not available.
Right indeed thx.
BTW, I think this patch now makes libexpat a hard requirement
for basic ARM Linux debugging.
OK I had not considered that at first, that sounds wrong to me compared
to the option of having a #define and no hard requirement on expat.
On the other hand expat is needed for debugging with GDBServer...
Yao, had you considered this ?
Is it not better to have a #define considering this ?
Thanks,
Antoine