This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/4] Add testcases to default.exp


>     add testcases about info:
>     *info extensions
>     *info handle
>     *info scope
>     *info win
>     add testcases about set width:
>     *set width -1

Just a couple of minor nits:

  1. "testcases" -> "tests"; the .exp file (Eg. default.exp) is
     a testcase, while a call to gdb_test executed a test. The testcase
     is a collection of tests usually logically related.

  2. We follow the GNU Coding Standards.
     https://sourceware.org/gdb/wiki/Internals%20Coding-Standards

     Above, sentences should start with a capital letter and end
     with a period (or a colon, as is more appropriate in your case).
     Therefore, start at the start of the line (no identation), and
     write "Add" instead of "add".

> gdb/testsuite/ChangeLog:
> 
>     * gdb.base/default.exp: Add new testcases.

Same as above, "testcases" -> "tests".

>  gdb/testsuite/gdb.base/default.exp | 10 ++++++++++
>  1 file changed, 10 insertions(+)

The changes themselves look good to me.

IIRC, I sent you the form to get started on copyright assignement,
so we'll need those to get through before we can accept your
contribution.

Thank you,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]