This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 10/18] Remote thread create/exit events
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 23 Nov 2015 15:41:01 +0000
- Subject: Re: [PATCH 10/18] Remote thread create/exit events
- Authentication-results: sourceware.org; auth=none
- References: <1444836486-25679-1-git-send-email-palves at redhat dot com> <1444836486-25679-11-git-send-email-palves at redhat dot com> <86eggh20rp dot fsf at gmail dot com>
On 10/26/2015 01:54 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
> Hi Pedro,
>
>> @@ -6417,6 +6425,11 @@ Packet: '%s'\n"),
>> one used by the original program. */
>> skipregs = 1;
>> }
>> + else if (strprefix (p, p1, "create"))
>> + {
>> + event->ws.kind = TARGET_WAITKIND_THREAD_CREATED;
>> + p = skip_to_semicolon (p1 + 1);
>> + }
>> else
>> {
>> ULONGEST pnum;
>
> Looks you add thread create/exit events on current stop notification.
> I am wondering why don't we add a new notification for thread
> create/exit. It should straightforward to add a new notification under
> current remote notification infrastructure.
Actually, TARGET_WAITKIND_THREAD_CREATED is really a stop, just like
TARGET_WAITKIND_FORKED, etc. That is, when it is reported, the thread
is stopped at its entry point.
Thanks,
Pedro Alves