This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 18 Nov 2015 11:48:03 -0500
- Subject: Re: [PATCH 0/6] [C++] Drop -fpermissive hack, enable -Werror
- Authentication-results: sourceware.org; auth=none
- References: <1447864802-24016-1-git-send-email-palves at redhat dot com>
On 15-11-18 11:39 AM, Pedro Alves wrote:
> The first 4 patches finally make GDB build cleanly in C++, at least on
> x86_64 GNU/Linux and x86_64 mingw. At this point, I think we should
> drop the -fpermissive hack and default to -Werror in C++ mode too,
> which is what the last two patches do.
>
> This lets the buildbot catch C++ build regressions promptly -- we
> already have a Fedora buildslave building in C++ mode specifically for
> that, but it currently misses regressions around pointer casts and
> enum conversions exactly due to -fpermissive/-Wno-error.
>
> Other ports still need further C++ conversion work, though the build
> failures shouldn't be too many and should be mostly localized to
> host/target-specific code.
>
> Pedro Alves (5):
> [C++] remote.c: Avoid enum arithmetic
> [C++] linux-thread-db.c: dladdr cast
> [C++] breakpoint.c: "no memory" software watchpoints and enum casts
> [C++] Drop -fpermissive hack
> [C++] Default to -Werror in C++ mode too
>
> Simon Marchi (1):
> [C++] s390: Fix enum gdb_syscall conversion
>
> gdb/breakpoint.c | 49 ++++++++++++++++++++++++++++++++++------------
> gdb/build-with-cxx.m4 | 3 +--
> gdb/configure | 10 +++-------
> gdb/configure.ac | 7 ++-----
> gdb/gdbserver/configure | 6 ++----
> gdb/gdbserver/configure.ac | 3 +--
> gdb/linux-thread-db.c | 2 +-
> gdb/remote.c | 2 +-
> gdb/s390-linux-tdep.c | 41 ++++++++++++++++++++++----------------
> gdb/target.c | 36 +++++++++++++++++++++++-----------
> gdb/target.h | 4 ++++
> 11 files changed, 100 insertions(+), 63 deletions(-)
>
This all looks good to me!