This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcin KoÅcielnicki <koriakin at 0x04 dot net>, qiyaoltc at gmail dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 02 Nov 2015 16:40:06 +0000
- Subject: Re: [PATCH v2 01/13] gdb/linux-record: Add testcases for a few syscalls.
- Authentication-results: sourceware.org; auth=none
- References: <5628E5D6 dot 5020706 at 0x04 dot net> <1445521166-14492-1-git-send-email-koriakin at 0x04 dot net> <5632035E dot 30809 at redhat dot com> <56327421 dot 6090203 at 0x04 dot net> <5633486B dot 40502 at redhat dot com> <5636BD98 dot 2090401 at 0x04 dot net>
On 11/02/2015 01:34 AM, Marcin KoÅcielnicki wrote:
> Well, this is embarassing...
> Turns out gdb_continue_to_breakpoint doesn't care all that much about
> the name of the breakpoint passed in as the first parameter, it just
> happily continues to the next breakpoint, whatever it happens to be.
> So the testcases as commited never actually make it to marker2, and they
> all trivially pass (state when reaching marker1 is, after all, exactly
> identical to reaching marker2 and then correctly reversing to marker1).
> I should've known that stepping over fork suddenly starting to work was
> too good to be true.
Whoops, sorry for missing that too.
> So... can I get that push access now and fix my mess, or do I no longer
> qualify as having submitted a good patch due to the above? :)
See "I need an account" at https://sourceware.org/. Say I approved it.
Once you have that sorted, add yourself to the "Write After Approval"
section in gdb/MAINTAINERS, push that change to the repo (no need
for approval on that one), and post that commit on the list.