This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] guile/: Add enum casts
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Thu, 29 Oct 2015 17:36:45 +0000
- Subject: Re: [PATCH] guile/: Add enum casts
- Authentication-results: sourceware.org; auth=none
- References: <1446058487-22472-1-git-send-email-palves at redhat dot com>
On 10/28/2015 06:54 PM, Pedro Alves wrote:
> In both cases the casts looks appropriate to me. In the
> gdbscm_disasm_memory_error case, the status is marshaled through the
> opcodes disassemble interface. In the
> gdbscm_unwind_stop_reason_string case, the int comes from Guile.
>
> gdb/ChangeLog:
> 2015-10-28 Pedro Alves <palves@redhat.com>
>
> * guile/scm-disasm.c (gdbscm_disasm_memory_error): Add cast.
> * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.
I split out the second hunk and pushed it in as an obvious change.
--------
From: Pedro Alves <palves@redhat.com>
Subject: [PATCH] guile/: Add enum cast
gdb/ChangeLog:
2015-10-29 Pedro Alves <palves@redhat.com>
* guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.
---
gdb/ChangeLog | 4 ++++
gdb/guile/scm-frame.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 000566e..9433221 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-10-29 Pedro Alves <palves@redhat.com>
+
+ * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast.
+
2015-10-29 Eli Zaretskii <eliz@gnu.org>
* utils.c (init_page_info): Disable paging if INSIDE_EMACS is set
diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c
index 24e26e8..55e0faf 100644
--- a/gdb/guile/scm-frame.c
+++ b/gdb/guile/scm-frame.c
@@ -1045,7 +1045,7 @@ gdbscm_unwind_stop_reason_string (SCM reason_scm)
if (reason < UNWIND_FIRST || reason > UNWIND_LAST)
scm_out_of_range (FUNC_NAME, reason_scm);
- str = unwind_stop_reason_to_string (reason);
+ str = unwind_stop_reason_to_string ((enum unwind_stop_reason) reason);
return gdbscm_scm_from_c_string (str);
}
--
1.9.3