This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdb/linux-record fixes
- From: Pedro Alves <palves at redhat dot com>
- To: Marcin KoÅcielnicki <koriakin at 0x04 dot net>, Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 29 Oct 2015 11:38:20 +0000
- Subject: Re: gdb/linux-record fixes
- Authentication-results: sourceware.org; auth=none
- References: <1445118081-10908-1-git-send-email-koriakin at 0x04 dot net> <56250E2D dot 7020009 at redhat dot com> <562525C1 dot 7000205 at 0x04 dot net> <5626206E dot 1000405 at redhat dot com> <5626226D dot 3010203 at 0x04 dot net> <5628E5D6 dot 5020706 at 0x04 dot net> <56320351 dot 7020409 at redhat dot com>
On 10/29/2015 11:30 AM, Pedro Alves wrote:
> On 10/22/2015 02:34 PM, Marcin KoÅcielnicki wrote:
>> On 20/10/15 13:15, Marcin KoÅcielnicki wrote:
>>> On 20/10/15 13:07, Pedro Alves wrote:
>>>> On 10/19/2015 06:17 PM, Marcin KoÅcielnicki wrote:
>>>>
>>>>> Yeah, they're not covered by the testsuite. Actually, there seem to be
>>>>> only two tests in gdb.reverse suite that even touch syscalls:
>>>>> sigall-reverse (signal, sigprocmask, exit_group) and watch-reverse
>>>>> (read, write). No wonder that syscall handling is buggy...
>>>>>
>>>>> Stepping forward and backward over pipe/time/waitpid would indeed do the
>>>>> trick for patch #6.
>>>>
>>>> Can I convince you to add that to the patch (and likewise to others that
>>>> might not be overly hard)?
>>>
>>> I'll do that, if I'm not overcome by dejaGNU... I have no idea how that
>>> stuff works at the moment.
>>>
>>>> BTW, you'll also need to include ChangeLog entries. Please check here:
>>>>
>>>> https://sourceware.org/gdb/wiki/ContributionChecklist
>>>
>>> OK, will do.
>>>
>>
>> Here comes v2:
>
> Many thanks for this.
I sent comments to the test patch. Nothing major, they're almost ready.
And then read patches 2-13, and they all look good to me.
Thanks again for working on this.
Thanks,
Pedro Alves