This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 0/5] Software breakpoints support for ARM linux in GDBServer.


On 10/20/2015 05:48 PM, Antoine Tremblay wrote:
> In this v3 :
> 
> The main change is that the functions breakpoint_from_pc and
> breakpoint_from_kind are now called : breakpoint_kind_from_pc and
> sw_breakpoint_from_kind.
> 
> As suggested in : https://sourceware.org/ml/gdb-patches/2015-10/msg00287.html
> 
> Thank you Pedro

Thank you for working on this.

> the patch set is really more clear now.

I agree.

> Thus the patchset is restructured for that, patches have been renamed and
> reordered.

I replied to all patches individually, and in general this all LGTM now.
Feel free to push with the nits I pointed out fixed, if Yao is happy with
it as well.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]