This is the mail archive of the
mailing list for the GDB project.
RE: [PATCH 0/6] disasm, record: fix "record instruction-history /m"
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: "palves at redhat dot com" <palves at redhat dot com>, "dje at google dot com" <dje at google dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 12 Oct 2015 14:16:31 +0000
- Subject: RE: [PATCH 0/6] disasm, record: fix "record instruction-history /m"
- Authentication-results: sourceware.org; auth=none
- References: <1442847283-10200-1-git-send-email-markus dot t dot metzger at intel dot com>
> -----Original Message-----
> From: Metzger, Markus T
> Sent: Monday, September 21, 2015 4:55 PM
> To: email@example.com; firstname.lastname@example.org
> Cc: email@example.com
> Subject: [PATCH 0/6] disasm, record: fix "record instruction-history /m"
> Markus Metzger (6):
> disasm: change dump_insns to print a single instruction
> disasm: add struct disas_insn to describe to-be-disassembled
> disas: add gdb_disassembly_vec
> disasm: use entire line table in line_has_code_p
> disasm: determine preceding lines independent of last_line
> btrace: use gdb_disassembly_vec and new source interleaving method
Given the concerns about increased memory consumption and run-time
overhead in patch 3 and the changes to the source interleaving algorithm
in patches 4 and 5, I'd go with a modified version of my original RFC, i.e.
- patches 1 and 2 from this series
- the rfc patch to interleave sources in record-btrace.c
- patch 6 from this series
This will leave us with two source interleaving algorithms, one for a
consecutive range of memory, and one for a sequence of instructions
in the order in which they were recorded.
Both will use a slightly modified dump_insn to print instruction tuples.
I'm dropping the idea of preparing a vector of instructions to print and
and of trying to shoehorn record instruction-history's source interleaving
Does that sound OK?
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928