This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] btrace, test: avoid gdb.btrace/vdso.exp fail
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 09 Oct 2015 13:25:31 +0100
- Subject: Re: [PATCH] btrace, test: avoid gdb.btrace/vdso.exp fail
- Authentication-results: sourceware.org; auth=none
- References: <1443682701-378-1-git-send-email-markus dot t dot metzger at intel dot com>
On 10/01/2015 07:58 AM, Markus Metzger wrote:
> The vdso.exp test checks that we can access the VDSO memory when replaying.
>
> Depending on the line information generated by the compiler, runto_main may run
> to the line marked with bp.1 or stop before that line. The test incorrectly
> assumes that it will always run to the marked line and fails if it doesn't.
>
> The test does not really care about what is traced. It does care that GDB is
> replaying when capturing the second disassemble output.
>
> Reflect that in the test by ignoring the output of the stepping and record goto
> begin commands and by checking that GDB is actually replaying.
Looks good to me.
Thanks,
Pedro Alves