This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, FT32] sim: correctly simulate PM write port

From: Mike Frysinger <vapier at gentoo dot org>
To: James Bowman <james dot bowman at ftdichip dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Tue, 29 Sep 2015 00:02:18 -0400
Subject: Re: [PATCH, FT32] sim: correctly simulate PM write port
Authentication-results: sourceware.org; auth=none
References: <CA9BBF0458F83C4F9051448B941B57D11961FBDD at glaexch3>

On 28 Sep 2015 23:49, James Bowman wrote:
> +	  if (cpu->state.pm_unlock)
> +	    {
> +	      /* Write to PM */

GNU style uses full sentences and two spaces after the period:
	/* Write to PM.  */

> +	      ft32_write_item (sd, dw, cpu->state.pm_addr, d);
> +	      cpu->state.pm_addr += 4;
> +	    }

what happens on the hardware when the PM is locked ?
is no error/status/register changed ?
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- RE: [PATCH, FT32] sim: correctly simulate PM write port
  - From: James Bowman

References:
- [PATCH, FT32] sim: correctly simulate PM write port
  - From: James Bowman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]