This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [RFC] gdb: add disable-docs option
- From: Doug Evans <dje at google dot com>
- To: Romain Naour <romain dot naour at openwide dot fr>, gdb-patches <gdb-patches at sourceware dot org>, Yao Qi <yao dot qi at linaro dot org>, Thomas Petazzoni <thomas dot petazzoni at free-electrons dot com>
- Date: Thu, 24 Sep 2015 14:46:19 -0700
- Subject: Re: [PATCH] [RFC] gdb: add disable-docs option
- Authentication-results: sourceware.org; auth=none
- References: <1441532245-23124-1-git-send-email-romain dot naour at openwide dot fr> <20150924211221 dot GA10729 at vapier dot lan>
On Thu, Sep 24, 2015 at 2:12 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 06 Sep 2015 11:37, Romain Naour wrote:
>> If makeinfo is not found in the system then the missing
>> script is used to warn the user.
>>
>> Before commit e30465112ed4c6320dd19107302057a5f7712cf2 the missing
>> script returned 0 after printing the message.
>>
>> Now, missing return 127 (command not found) to the Makefile and
>> the build fail.
>>
>> As suggested [1], add a new option to disable the documentation.
>
> aren't info pages shipped as part of the release ? so even if makeinfo isn't
> available, it doesn't matter as the pages aren't regenerated on the user's
> system. maybe you're applying patches to the source that cause the docs to be
> regenerated ? if that's the case, i think disabling the docs entirely is the
> wrong way to go. instead it should be skipping the regeneration step and
> installing the pages that already exist. alternatively, you can adjust your
> build to update the timestamps of the generated files so the build won't try
> to regenerate them.
> -mike
Agreed.
Sometimes releases have gone out with bad timestamps which need to be
fixed, but yeah there should be no need to disable doc generation.