This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 17/17] infrun: scheduler-locking reverse
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 16 Sep 2015 14:23:49 +0100
- Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse
- Authentication-results: sourceware.org; auth=none
- References: <1441794909-32718-1-git-send-email-markus dot t dot metzger at intel dot com> <1441794909-32718-18-git-send-email-markus dot t dot metzger at intel dot com> <55F03A12 dot 80307 at redhat dot com> <20150912194344 dot GA7575 at host1 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B23331AE05D at IRSMSX104 dot ger dot corp dot intel dot com> <20150915171931 dot GA2056 at host1 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B23331AE557 at IRSMSX104 dot ger dot corp dot intel dot com> <A78C989F6D9628469189715575E55B23331AE894 at IRSMSX104 dot ger dot corp dot intel dot com>
On 09/16/2015 01:44 PM, Metzger, Markus T wrote:
> + For all-stop targets, we only step INFERIOR_PTID and continue others. */
> + if (!target_is_non_stop_p () && ptid_match (inferior_ptid, ptid))
> + {
I'd remove that ptid_match.
> +with_test_prefix "schedlock-reverse" {
> + gdb_test_no_output "set scheduler-locking reverse"
> +
> + test_navigate
> + test_step
> + test_cont
> + test_rstep
> + test_goto_end
> +}
> +
> +with_test_prefix "schedlock-on" {
> + gdb_test_no_output "set scheduler-locking on"
> +
> + test_navigate
> + test_step
> + test_cont
> + test_rstep
> + test_goto_end
> +}
> +
> +with_test_prefix "schedlock-step" {
> + gdb_test_no_output "set scheduler-locking step"
> +
> + test_navigate
> + test_step
> + test_cont_all
> + test_rstep
> + test_goto_end
> +}
You can fold all these using foreach. E.g.,
foreach schedlock {"reverse" "on" "step"} {
with_test_prefix "schedlock-$schedlock" {
gdb_test_no_output "set scheduler-locking $schedlock"
test_navigate
test_step
test_cont_all
test_rstep
test_goto_end
}
}
Otherwise LGTM.
Thanks,
Pedro Alves