Re: [PATCH 7/7] Support tracepoints and software breakpoints on ARM aarch32-linux in GDBServer.

[Antoine Tremblay <antoine dot tremblay at ericsson dot com>]

On 09/11/2015 08:30 AM, Eli Zaretskii wrote:
> > -@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}]@r{[}-@r{]}
> > +@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}][:K@var{kind}]@r{[}-@r{]}
> >   @cindex @samp{QTDP} packet
> >   Create a new tracepoint, number @var{n}, at @var{addr}.  If @var{ena}
> >   is @samp{E}, then the tracepoint is enabled; if it is @samp{D}, then
> > -the tracepoint is disabled.  The @var{step} gives the tracepoint's step
> > -count, and @var{pass} gives its pass count.  If an @samp{F} is present,
> > -then the tracepoint is to be a fast tracepoint, and the @var{flen} is
> > -the number of bytes that the target should copy elsewhere to make room
> > -for the tracepoint.  If an @samp{X} is present, it introduces a
> > -tracepoint condition, which consists of a hexadecimal length, followed
> > -by a comma and hex-encoded bytes, in a manner similar to action
> > -encodings as described below.  If the trailing @samp{-} is present,
> > -further @samp{QTDP} packets will follow to specify this tracepoint's
> > -actions.
> > +the tracepoint is disabled.  The @var{step} gives the tracepoint's
> > +step count, and @var{pass} gives its pass count.  If an @samp{F} is
> > +present, then the tracepoint is to be a fast tracepoint, and the
> > +@var{flen} is the number of bytes that the target should copy
> > +elsewhere to make room for the tracepoint.  If an @samp{X} is present,
> > +it introduces a tracepoint condition, which consists of a hexadecimal
> > +length, followed by a comma and hex-encoded bytes, in a manner similar
>
> Please in the future try not to re-fill previous text: it makes harder
> for me to find your changes among a potentially large paragraph, such
> as this one.

OK sorry about that.

> > +to action encodings as described below.  If a @samp{K} is present, it
> > +indicates a target specific breakpoint length.  E.g., the arm and mips
> > +can insert either a 2 or 4 byte breakpoint. Some architectures have
> > +additional meanings for kind see : @ref{Architecture-Specific Protocol
> > +Details} .
>
> There's no need for the colon ':' after "see", and please delete the
> space before the period that ends the last sentence above.

Done

> Otherwise, the documentation parts are OK.  Thanks.
Thanks.