This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 15/17] btrace: allow full memory and register access for non-replaying threads
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 09 Sep 2015 12:57:36 +0100
- Subject: Re: [PATCH 15/17] btrace: allow full memory and register access for non-replaying threads
- Authentication-results: sourceware.org; auth=none
- References: <1441794909-32718-1-git-send-email-markus dot t dot metzger at intel dot com> <1441794909-32718-16-git-send-email-markus dot t dot metzger at intel dot com>
On 09/09/2015 11:35 AM, Markus Metzger wrote:
> @@ -1314,7 +1314,7 @@ record_btrace_store_registers (struct target_ops *ops,
> struct target_ops *t;
>
> if (!record_btrace_generating_corefile
> - && record_btrace_is_replaying (ops, minus_one_ptid))
> + && record_btrace_is_replaying (ops, inferior_ptid))
> error (_("This record target does not allow writing registers."));
>
I'd suggest also tweaking the error string.
"Cannot write registers of thread that is replaying" or some such.
Thanks,
Pedro Alves