This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 03/19] Implement completion-limiting for complete_on_cmdlist.
- From: Doug Evans <xdje42 at gmail dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 22 Aug 2015 18:04:09 -0700
- Subject: Re: [PATCH v3 03/19] Implement completion-limiting for complete_on_cmdlist.
- Authentication-results: sourceware.org; auth=none
- References: <20150806191404 dot 32159 dot 50755 dot stgit at valrhona dot uglyboxes dot com> <20150806191517 dot 32159 dot 91797 dot stgit at valrhona dot uglyboxes dot com>
Keith Seitz <keiths@redhat.com> writes:
> Differences in this revision:
>
> 1. Remove partial copy code from complete_on_cmdlist.
>
> ---
>
> This is the first of a series of smaller patches to switch over
> all completion functions to using add_completion to add
> completions to the completion list to be presented to the user.
>
> Note that in order to verify that this patch works as intended,
> one must override the backup completion counting in complete_line.
> [This backup code will be permanently removed in a later patch.]
> During testing, I have verified all patches with this planned code
> removal to verify that it works.
>
> First up is complete_on_cmdlist. Completion-limiting is already tested
> in gdb.base/completion.exp, so there are no new tests.
>
> gdb/ChangeLog
>
> * cli/cli-decode.c (complete_on_cmdlist): Use add_completion
> to determine whether to continue looking for completions.
LGTM